Add support for gateway addresses field #3896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3896 +/- ##
=======================================
Coverage 86.80% 86.81%
=======================================
Files 128 128
Lines 16547 16575 +28
Branches 62 62
=======================================
+ Hits 14364 14389 +25
- Misses 2003 2006 +3
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjee19
commented
Sep 11, 2025
bjee19
commented
Sep 11, 2025
sjberman
reviewed
Sep 11, 2025
|
We should do manual testing for only IPv6 environment for this. |
salonichf5
reviewed
Sep 12, 2025
sjberman
reviewed
Sep 12, 2025
|
Should we have some mention of what the gateway.spec.addresses field actually does? Since its implementation specific I think we do. I'll update the gateway compatibility doc, but i'm wondering if the functionality should be condensed into that document. Or if we should make a separate document for it, any thoughts? |
|
nginx/documentation#1109 is associated compatibility document update. |
salonichf5
reviewed
Sep 15, 2025
salonichf5
reviewed
Sep 15, 2025
sjberman
approved these changes
Sep 16, 2025
bjee19
force-pushed
the
enh/support-gateway-addresses-field
branch
from
e3f402c to
5468ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Users would like a way to specify addresses for all incoming traffic to use through the GatewaySpecAddresses field.
Solution: Implement the GatewaySpecAddresses field by adding the validated addresses to the externalIP field on the NGINX service.
Testing: GatewayStaticAddresses conformance test passes. Manually verified service externalIP field is set correctly. Manually verified conditions on Gateway.
Closes #2944
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.